content/renderer/pepper/pepper_graphics_2d_host.cc - Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_graphics_2d_host.cc

Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_graphics_2d_host.cc

diff --git a/content/renderer/pepper/pepper_graphics_2d_host.cc b/content/renderer/pepper/pepper_graphics_2d_host.cc

index 19a295f5eb17f5d6487fc0826e77302c55c72841..853e606e25fa14d2ddb22b7de5c0ff7782b2844b 100644

--- a/content/renderer/pepper/pepper_graphics_2d_host.cc

+++ b/content/renderer/pepper/pepper_graphics_2d_host.cc

@@ -347,7 +347,7 @@ void PepperGraphics2DHost::Paint(blink::WebCanvas* canvas,

SkAutoCanvasRestore auto_restore(canvas, true);

SkRect image_data_rect =

gfx::RectToSkRect(gfx::Rect(plugin_rect.origin(), image_size));

- canvas->clipRect(image_data_rect, SkRegion::kDifference_Op);

+ canvas->clipRect(image_data_rect, kDifference_SkClipOp);

SkPaint paint;

paint.setXfermodeMode(SkXfermode::kSrc_Mode);

« no previous file with comments | « content/browser/devtools/protocol/color_picker.cc ('k') | content/renderer/skia_benchmarking_extension_unittest.cc » ('j') | no next file with comments »