Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768493002: Get rid of CompositingState. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of CompositingState. It's always NotComposited. Also removed some DisableCompositingQueryAsserts. The asserts they are disabling no longer exist. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/552023550f58527f0a18334f4c68c2e853eebb09

Patch Set 1 #

Patch Set 2 : fix incorrect case. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -183 lines) Patch
M sky/engine/core/animation/Animation.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/animation/CompositorAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/editing/Caret.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +1 line, -4 lines 1 comment Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/LayerPaintingInfo.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/PaintPhase.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 3 chunks +2 lines, -16 lines 1 comment Download
M sky/engine/core/rendering/RenderLayer.h View 4 chunks +2 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 11 chunks +6 lines, -54 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerRepainter.cpp View 4 chunks +3 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 3 chunks +1 line, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 5 chunks +1 line, -22 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingState.h View 1 chunk +0 lines, -29 lines 0 comments Download
M sky/engine/web/LinkHighlight.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
https://codereview.chromium.org/768493002/diff/20001/sky/engine/core/rendering/RenderBox.cpp File sky/engine/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/768493002/diff/20001/sky/engine/core/rendering/RenderBox.cpp#newcode923 sky/engine/core/rendering/RenderBox.cpp:923: void RenderBox::paintClippingMask(PaintInfo& paintInfo, const LayoutPoint& paintOffset) It looks like ...
6 years ago (2014-11-27 02:09:20 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/768493002/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/768493002/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode157 sky/engine/core/frame/FrameView.cpp:157: // FIXME(sky): Parent is always null in sky? ...
6 years ago (2014-11-27 02:48:43 UTC) #3
ojan
6 years ago (2014-11-27 02:49:41 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
552023550f58527f0a18334f4c68c2e853eebb09.

Powered by Google App Engine
This is Rietveld 408576698