Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 768493002: Get rid of CompositingState. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix incorrect case. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 } 246 }
247 247
248 // The caret rect needs to be invalidated after scrolling 248 // The caret rect needs to be invalidated after scrolling
249 frame->selection().setCaretRectNeedsUpdate(); 249 frame->selection().setCaretRectNeedsUpdate();
250 250
251 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previou sPaintInvalidationRect()); 251 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previou sPaintInvalidationRect());
252 252
253 quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad( quadForFakeMouseMoveEvent); 253 quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad( quadForFakeMouseMoveEvent);
254 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 254 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
255 255
256 // For querying RenderLayer::compositingState()
257 // This code appears correct, since scrolling outside of layout happens duri ng activities that do not dirty compositing state.
258 DisableCompositingQueryAsserts disabler;
259 if (box().frameView()->isInPerformLayout()) 256 if (box().frameView()->isInPerformLayout())
260 box().setShouldDoFullPaintInvalidation(true); 257 box().setShouldDoFullPaintInvalidation(true);
261 else 258 else
262 box().invalidatePaintUsingContainer(paintInvalidationContainer, layer()- >renderer()->previousPaintInvalidationRect(), InvalidationScroll); 259 box().invalidatePaintUsingContainer(paintInvalidationContainer, layer()- >renderer()->previousPaintInvalidationRect(), InvalidationScroll);
263 260
264 // Schedule the scroll DOM event. 261 // Schedule the scroll DOM event.
265 if (box().node()) 262 if (box().node())
266 box().node()->document().enqueueScrollEventForNode(box().node()); 263 box().node()->document().enqueueScrollEventForNode(box().node());
267 } 264 }
268 265
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild) 812 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild)
816 { 813 {
817 // We only want to track the topmost scroll child for scrollable areas with 814 // We only want to track the topmost scroll child for scrollable areas with
818 // overlay scrollbars. 815 // overlay scrollbars.
819 if (!hasOverlayScrollbars()) 816 if (!hasOverlayScrollbars())
820 return; 817 return;
821 m_nextTopmostScrollChild = scrollChild; 818 m_nextTopmostScrollChild = scrollChild;
822 } 819 }
823 820
824 } // namespace blink 821 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698