Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: sky/engine/core/frame/FrameView.cpp

Issue 768493002: Get rid of CompositingState. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix incorrect case. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 reset(); 147 reset();
148 } 148 }
149 149
150 bool FrameView::didFirstLayout() const 150 bool FrameView::didFirstLayout() const
151 { 151 {
152 return !m_firstLayout; 152 return !m_firstLayout;
153 } 153 }
154 154
155 void FrameView::invalidateRect(const IntRect& rect) 155 void FrameView::invalidateRect(const IntRect& rect)
156 { 156 {
157 // For querying RenderLayer::compositingState() when invalidating scrollbars . 157 // FIXME(sky): Parent is always null in sky?
abarth-chromium 2014/11/27 02:48:42 Yes.
158 // FIXME: do all scrollbar invalidations after layout of all frames is compl ete. It's currently not recursively true.
159 DisableCompositingQueryAsserts disabler;
160 if (!parent()) { 158 if (!parent()) {
161 if (HostWindow* window = hostWindow()) 159 if (HostWindow* window = hostWindow())
162 window->invalidateContentsAndRootView(rect); 160 window->invalidateContentsAndRootView(rect);
163 return;
164 } 161 }
165 } 162 }
166 163
167 void FrameView::setFrameRect(const IntRect& newRect) 164 void FrameView::setFrameRect(const IntRect& newRect)
168 { 165 {
169 IntRect oldRect = frameRect(); 166 IntRect oldRect = frameRect();
170 if (newRect == oldRect) 167 if (newRect == oldRect)
171 return; 168 return;
172 169
173 Widget::setFrameRect(newRect); 170 Widget::setFrameRect(newRect);
(...skipping 851 matching lines...) Expand 10 before | Expand all | Expand 10 after
1025 void FrameView::setLayoutSizeInternal(const IntSize& size) 1022 void FrameView::setLayoutSizeInternal(const IntSize& size)
1026 { 1023 {
1027 if (m_layoutSize == size) 1024 if (m_layoutSize == size)
1028 return; 1025 return;
1029 1026
1030 m_layoutSize = size; 1027 m_layoutSize = size;
1031 contentsResized(); 1028 contentsResized();
1032 } 1029 }
1033 1030
1034 } // namespace blink 1031 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698