Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 766753006: clean up default precision handling (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@precision
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M include/gpu/GrShaderVar.h View 1 chunk +7 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bsalomon
6 years ago (2014-12-03 18:40:25 UTC) #1
joshualitt
lgtm
6 years ago (2014-12-03 18:48:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753006/1
6 years ago (2014-12-03 18:50:14 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years ago (2014-12-04 00:50:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753006/1
6 years ago (2014-12-04 14:56:06 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years ago (2014-12-04 20:56:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753006/1
6 years ago (2014-12-04 21:02:42 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-04 21:02:52 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c92aadcf9a49e85b21293a96d73a2d0a8a08fe64

Powered by Google App Engine
This is Rietveld 408576698