Revert of Extract WebGraphicsContext3DImpl from webkit/common/gpu.

Revert of Extract WebGraphicsContext3DImpl from webkit/common/gpu. (patchset #12 id:220001 of https://codereview.chromium.org/761243002/)

Reason for revert:
Suspecting as cause for Win8 GN compile fail

Original issue's description:
> Extract WebGraphicsContext3DImpl from webkit/common/gpu.
>
> We decided that it should be fine to move it to gpu/blink now, similar
> to gpu/skia_bindings and cc/blink.
>
> BUG=338338
> TEST=links
> R=piman@chromium.org,jamesr@chromium.org
> TBR=
>
> Committed: https://crrev.com/a962b5f152a0a331bc2e1a5a0d4d38e8adece10d
> Cr-Commit-Position: refs/heads/master@{#306957}

TBR=jamesr@chromium.org,piman@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338338
Committed: https://crrev.com/c838415edd21dbae71740277487c733898a62ea0
Cr-Commit-Position: refs/heads/master@{#306985}

[samli, 2014-12-05 05:14:08]

Created Revert of Extract WebGraphicsContext3DImpl from webkit/common/gpu.

[commit-bot: I haz the power, 2014-12-05 05:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763963003/1

[commit-bot: I haz the power, 2014-12-05 05:15:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-05 05:15:46]

Patchset 1 (id:??) landed as
https://crrev.com/c838415edd21dbae71740277487c733898a62ea0
Cr-Commit-Position: refs/heads/master@{#306985}

[tfarina, 2014-12-05 11:43:38]

Samli, could you send me the url to the win8 gn failure? Or paste here the
error?

So win8 gn is not run in trybots? That is annoying, I will ask Dirk.

[samli, 2014-12-05 12:39:00]

No, they're not. Part of the waterfall.
http://build.chromium.org/p/chromium.win/waterfall?builder=Win8%20GN%20(dbg)
Scroll down to see the compile failures before the revert.

On Fri, 5 Dec 2014 22:43 null <tfarina@chromium.org> wrote:

> Samli, could you send me the url to the win8 gn failure? Or paste here the
> error?
>
> So win8 gn is not run in trybots? That is annoying, I will ask Dirk.
>
>
>
> https://codereview.chromium.org/763963003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-12-05 14:15:32]

On Fri, Dec 5, 2014 at 10:38 AM, Samuel Li <samli@chromium.org> wrote:

> No, they're not. Part of the waterfall.
>
> http://build.chromium.org/p/chromium.win/waterfall?builder=Win8%20GN%20(dbg)
> Scroll down to see the compile failures before the revert.
>
> Do you know the Build number?

The random ones I looked at didn't seem related to my CL.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-12-05 14:18:15]

On Fri, Dec 5, 2014 at 12:15 PM, Thiago Farina <tfarina@chromium.org> wrote:

>
>
> On Fri, Dec 5, 2014 at 10:38 AM, Samuel Li <samli@chromium.org> wrote:
>
>> No, they're not. Part of the waterfall.
>>
>> http://build.chromium.org/p/chromium.win/waterfall?builder=Win8%20GN%20(dbg)
>> Scroll down to see the compile failures before the revert.
>>
>> Do you know the Build number?
>
> The random ones I looked at didn't seem related to my CL.
>
>
The failure in
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/1357 and

http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build...
do not seem related to my patch.

c:\b\build\slave\win8_gn__dbg_\build\src\ui\base\test\ui_controls_win.cc(28)
: error C2664: 'bool
ui_controls::internal::SendKeyPressImpl(HWND,ui::KeyboardCode,bool,bool,bool,const
base::Closure &)' : cannot convert argument 1 from 'gfx::NativeWindow'
to 'HWND'
        Types pointed to are unrelated; conversion requires
reinterpret_cast, C-style cast or function-style cast
c:\b\build\slave\win8_gn__dbg_\build\src\ui\base\test\ui_controls_win.cc(40)
: error C2664: 'bool
ui_controls::internal::SendKeyPressImpl(HWND,ui::KeyboardCode,bool,bool,bool,const
base::Closure &)' : cannot convert argument 1 from 'gfx::NativeWindow'
to 'HWND'
        Types pointed to are unrelated; conversion requires
reinterpret_cast, C-style cast or function-style cast

ninja: build stopped: subcommand failed.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.