Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 761243002: Extract WebGraphicsContext3DImpl from webkit/common/gpu. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Extract WebGraphicsContext3DImpl from webkit/common/gpu. We decided that it should be fine to move it to gpu/blink now, similar to gpu/skia_bindings and cc/blink. BUG=338338 TEST=links R=piman@chromium.org,jamesr@chromium.org TBR= Committed: https://crrev.com/a962b5f152a0a331bc2e1a5a0d4d38e8adece10d Cr-Commit-Position: refs/heads/master@{#306957}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : fix GN - content_shell links #

Total comments: 2

Patch Set 6 : blink_minimal #

Patch Set 7 : fix patch set 6 #

Total comments: 4

Patch Set 8 : fix build error? #

Patch Set 9 : fix GN ordering #

Patch Set 10 : fix win and android build errors? #

Patch Set 11 : fix win and android_webview? #

Patch Set 12 : more win fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -1721 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/android_webview.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -0 lines 0 comments Download
A gpu/blink/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +30 lines, -0 lines 0 comments Download
A + gpu/blink/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A gpu/blink/gpu_blink.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +36 lines, -0 lines 0 comments Download
A gpu/blink/gpu_blink_export.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_impl.h View 1 2 3 4 5 6 7 5 chunks +27 lines, -29 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_impl.cc View 4 chunks +4 lines, -6 lines 0 comments Download
D webkit/DEPS View 1 chunk +0 lines, -16 lines 0 comments Download
M webkit/common/gpu/BUILD.gn View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
A + webkit/common/gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_impl.h View 1 chunk +0 lines, -614 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_impl.cc View 1 chunk +0 lines, -1032 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (1 generated)
tfarina
Could you guys take a look in advance? I still need to fix GN build ...
6 years ago (2014-11-28 15:15:03 UTC) #1
piman
https://codereview.chromium.org/761243002/diff/60001/gpu/blink/BUILD.gn File gpu/blink/BUILD.gn (right): https://codereview.chromium.org/761243002/diff/60001/gpu/blink/BUILD.gn#newcode14 gpu/blink/BUILD.gn:14: "//gpu/skia_bindings", Do you need these last 2 dependencies?
6 years ago (2014-12-01 18:32:05 UTC) #2
jamesr
https://codereview.chromium.org/761243002/diff/60001/gpu/blink/webgraphicscontext3d_impl.h File gpu/blink/webgraphicscontext3d_impl.h (right): https://codereview.chromium.org/761243002/diff/60001/gpu/blink/webgraphicscontext3d_impl.h#newcode17 gpu/blink/webgraphicscontext3d_impl.h:17: using blink::WGC3Dbitfield; you can't put 'using' statements in header ...
6 years ago (2014-12-01 20:11:09 UTC) #3
tfarina
https://codereview.chromium.org/761243002/diff/60001/gpu/blink/webgraphicscontext3d_impl.h File gpu/blink/webgraphicscontext3d_impl.h (right): https://codereview.chromium.org/761243002/diff/60001/gpu/blink/webgraphicscontext3d_impl.h#newcode17 gpu/blink/webgraphicscontext3d_impl.h:17: using blink::WGC3Dbitfield; On 2014/12/01 20:11:09, jamesr wrote: > you ...
6 years ago (2014-12-02 01:28:09 UTC) #4
jamesr
Looks like that was just a move as well. I'm not sure where these using ...
6 years ago (2014-12-02 01:30:13 UTC) #5
tfarina
On 2014/12/02 01:30:13, jamesr wrote: > Looks like that was just a move as well. ...
6 years ago (2014-12-02 01:34:49 UTC) #6
tfarina
James, Antoine, ptal.
6 years ago (2014-12-03 00:52:06 UTC) #7
jamesr
https://codereview.chromium.org/761243002/diff/80001/gpu/blink/gpu_blink.gyp File gpu/blink/gpu_blink.gyp (right): https://codereview.chromium.org/761243002/diff/80001/gpu/blink/gpu_blink.gyp#newcode18 gpu/blink/gpu_blink.gyp:18: '../../third_party/WebKit/public/blink.gyp:blink', nack, you can only depend on blink_minimal
6 years ago (2014-12-03 00:58:29 UTC) #8
tfarina
https://codereview.chromium.org/761243002/diff/80001/gpu/blink/gpu_blink.gyp File gpu/blink/gpu_blink.gyp (right): https://codereview.chromium.org/761243002/diff/80001/gpu/blink/gpu_blink.gyp#newcode18 gpu/blink/gpu_blink.gyp:18: '../../third_party/WebKit/public/blink.gyp:blink', On 2014/12/03 00:58:28, jamesr wrote: > nack, you ...
6 years ago (2014-12-03 21:46:30 UTC) #9
jamesr
lgtm (although the bots don't seem happy yet) https://codereview.chromium.org/761243002/diff/120001/gpu/blink/BUILD.gn File gpu/blink/BUILD.gn (right): https://codereview.chromium.org/761243002/diff/120001/gpu/blink/BUILD.gn#newcode21 gpu/blink/BUILD.gn:21: sources ...
6 years ago (2014-12-03 22:19:52 UTC) #10
piman
LGTM after build is fixed and James's comments are addressed.
6 years ago (2014-12-03 22:31:33 UTC) #11
tfarina
https://codereview.chromium.org/761243002/diff/120001/gpu/blink/BUILD.gn File gpu/blink/BUILD.gn (right): https://codereview.chromium.org/761243002/diff/120001/gpu/blink/BUILD.gn#newcode21 gpu/blink/BUILD.gn:21: sources = [ On 2014/12/03 22:19:52, jamesr wrote: > ...
6 years ago (2014-12-04 00:21:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761243002/220001
6 years ago (2014-12-05 01:02:13 UTC) #14
commit-bot: I haz the power
Committed patchset #12 (id:220001)
6 years ago (2014-12-05 02:04:24 UTC) #15
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/a962b5f152a0a331bc2e1a5a0d4d38e8adece10d Cr-Commit-Position: refs/heads/master@{#306957}
6 years ago (2014-12-05 02:05:34 UTC) #16
samli
6 years ago (2014-12-05 05:14:08 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/763963003/ by samli@chromium.org.

The reason for reverting is: Suspecting as cause for Win8 GN compile fail.

Powered by Google App Engine
This is Rietveld 408576698