Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 754963007: Revert of Move TouchSelectionController from content to ui (Closed)

Created:
6 years ago by Ryan Sleevi
Modified:
6 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move TouchSelectionController from content to ui (patchset #12 id:600001 of https://codereview.chromium.org/759433002/) Reason for revert: Suspected of causing Win8 GN failure http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/1552/steps/compile/logs/stdio#error1 FAILED: ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj.rsp /c ../../ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc /Foobj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj /Fdobj/ui/base/ui_base_unittests_cc.pdb c:\b\build\slave\win8_gn\build\src\ui\base\dragdrop\os_exchange_data_provider_aurax11.h(8) : fatalerror C1083: Cannot open include file: 'X11/Xlib.h': No such file or directory Original issue's description: > Move TouchSelectionController from content to ui > > This patch is only moving new unified touch selection files from > content/ to ui/touch_selection/. This is the first step to allow Aura > use the new unified TouchSelectionController. > > The only change to TouchSelectionController needed for this move is > replacing use of cc::ViewportSelectionBound with ui::SelectionBound. > > The actual use of the new touch selection for Aura will happen in future > CL(s). After that, we can remove current touch selection code from > ui/base/touch/. > > BUG=399721 > > Committed: https://crrev.com/29fd405ca491a6fcf0dde6277d92d44300cb2926 > Cr-Commit-Position: refs/heads/master@{#307336} TBR=jdduke@chromium.org,mfomitchev@chromium.org,sadrul@chromium.org,boliu@chromium.org,jam@chromium.org,mohsen@chromium.org NOTREECHECKS=true NOTRY=true BUG=399721 Committed: https://crrev.com/6b150518257d898af57991939f9481bc3e95b5e7 Cr-Commit-Position: refs/heads/master@{#307344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2673 lines, -2965 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M android_webview/java_library_common.mk View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/libwebviewchromium.gypi View 2 chunks +1 line, -1 line 0 comments Download
M build/all.gyp View 8 chunks +0 lines, -16 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/composited_touch_handle_drawable.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/composited_touch_handle_drawable.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A content/browser/renderer_host/input/selection_event_type.h View 1 chunk +29 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_handle.h View 1 chunk +134 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_handle.cc View 1 chunk +264 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_handle_unittest.cc View 1 chunk +492 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_selection_controller.h View 1 chunk +154 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_selection_controller.cc View 1 chunk +435 lines, -0 lines 0 comments Download
A content/browser/renderer_host/input/touch_selection_controller_unittest.cc View 1 chunk +845 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content.gyp View 3 chunks +9 lines, -1 line 0 comments Download
M content/content_browser.gypi View 3 chunks +6 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
D ui/base/touch/selection_bound.h View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/base/touch/selection_bound.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D ui/base/touch/selection_bound_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +32 lines, -6 lines 0 comments Download
M ui/base/touch/touch_editing_controller.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A ui/base/touch/touch_editing_controller_unittest.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/touch_selection/BUILD.gn View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/touch_selection/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/touch_selection/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/touch_selection/selection_event_type.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/touch_selection/touch_handle.h View 1 chunk +0 lines, -134 lines 0 comments Download
D ui/touch_selection/touch_handle.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D ui/touch_selection/touch_handle_unittest.cc View 1 chunk +0 lines, -492 lines 0 comments Download
D ui/touch_selection/touch_selection_controller.h View 1 chunk +0 lines, -148 lines 0 comments Download
D ui/touch_selection/touch_selection_controller.cc View 1 chunk +0 lines, -433 lines 0 comments Download
D ui/touch_selection/touch_selection_controller_unittest.cc View 1 chunk +0 lines, -842 lines 0 comments Download
D ui/touch_selection/ui_touch_selection.gyp View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/touch_selection/ui_touch_selection_export.h View 1 chunk +0 lines, -37 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 8 chunks +40 lines, -46 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
Created Revert of Move TouchSelectionController from content to ui
6 years ago (2014-12-08 21:50:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754963007/1
6 years ago (2014-12-08 21:52:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 21:53:50 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-08 21:55:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b150518257d898af57991939f9481bc3e95b5e7
Cr-Commit-Position: refs/heads/master@{#307344}

Powered by Google App Engine
This is Rietveld 408576698