Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 753183003: Fix an issue resolving paths when remote debugging. (Closed)

Created:
6 years ago by devoncarew
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix an issue resolving paths when remote debugging. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41976

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -65 lines) Patch
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java View 3 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartiumLaunchConfigurationDelegate.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/mobile/MobileLaunchConfigurationDelegate.java View 3 chunks +2 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugTarget.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java View 1 1 chunk +14 lines, -14 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmLibraryRef.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/source/UriToFileResolver.java View 9 chunks +48 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/IRemoteConnectionDelegate.java View 2 chunks +3 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/dialogs/RemoteConnectionDialog.java View 12 chunks +57 lines, -23 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
devoncarew
Fix https://code.google.com/p/dart/issues/detail?id=21280 - change the remote connection dialog to take a 'project source' location, and ...
6 years ago (2014-11-25 18:27:35 UTC) #2
scheglov
LGTM
6 years ago (2014-11-25 18:56:36 UTC) #3
devoncarew
6 years ago (2014-11-26 02:23:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r41976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698