Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java

Issue 753183003: Fix an issue resolving paths when remote debugging. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java (revision 41867)
+++ editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java (working copy)
@@ -28,7 +28,7 @@
import com.google.dart.tools.debug.core.util.IRemoteConnectionDelegate;
import org.apache.commons.lang3.ObjectUtils;
-import org.eclipse.core.resources.IFile;
+import org.eclipse.core.resources.IContainer;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException;
@@ -94,7 +94,7 @@
}
@Override
- public IDebugTarget performRemoteConnection(String host, int port, IFile file,
+ public IDebugTarget performRemoteConnection(String host, int port, IContainer container,
IProgressMonitor monitor, boolean usePubServe) throws CoreException {
if (monitor == null) {
monitor = new NullProgressMonitor();
@@ -107,10 +107,10 @@
monitor.beginTask("Opening Connection...", 1);
try {
- if (file != null) {
+ if (container != null) {
ILaunchConfiguration launchConfiguration = launch.getLaunchConfiguration();
DartLaunchConfigWrapper wrapper = new DartLaunchConfigWrapper(launchConfiguration);
- wrapper.setApplicationName(file.getFullPath().toPortableString());
+ wrapper.setSourceDirectoryName(container.getFullPath().toPortableString());
}
CoreLaunchUtils.addLaunch(launch);

Powered by Google App Engine
This is Rietveld 408576698