Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java

Issue 753183003: Fix an issue resolving paths when remote debugging. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java (revision 41867)
+++ editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java (working copy)
@@ -829,20 +829,20 @@
// TODO(scheglov) commented out on 2014-09-25
// I still can step into SDK libraries without it.
// And with it VM sometimes ignores "resume" command and application just hangs.
-// try {
-// JSONObject request = new JSONObject();
-//
-// request.put("command", "setLibraryProperties");
-// request.put(
-// "params",
-// new JSONObject().put("libraryId", libraryId).put(
-// "debuggingEnabled",
-// Boolean.toString(debuggingEnabled)));
-//
-// sendRequest(request, isolate.getId(), null);
-// } catch (JSONException exception) {
-// throw new IOException(exception);
-// }
+ try {
+ JSONObject request = new JSONObject();
+
devoncarew 2014/11/25 18:27:35 Commented this back in; w/o it we can't step into
+ request.put("command", "setLibraryProperties");
+ request.put(
+ "params",
+ new JSONObject().put("libraryId", libraryId).put(
+ "debuggingEnabled",
+ Boolean.toString(debuggingEnabled)));
+
+ sendRequest(request, isolate.getId(), null);
+ } catch (JSONException exception) {
+ throw new IOException(exception);
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698