Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java

Issue 753183003: Fix an issue resolving paths when remote debugging. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012, the Dart project authors. 2 * Copyright (c) 2012, the Dart project authors.
3 * 3 *
4 * Licensed under the Eclipse Public License v1.0 (the "License"); you may not u se this file except 4 * Licensed under the Eclipse Public License v1.0 (the "License"); you may not u se this file except
5 * in compliance with the License. You may obtain a copy of the License at 5 * in compliance with the License. You may obtain a copy of the License at
6 * 6 *
7 * http://www.eclipse.org/legal/epl-v10.html 7 * http://www.eclipse.org/legal/epl-v10.html
8 * 8 *
9 * Unless required by applicable law or agreed to in writing, software distribut ed under the License 9 * Unless required by applicable law or agreed to in writing, software distribut ed under the License
10 * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY K IND, either express 10 * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY K IND, either express
(...skipping 811 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 * 822 *
823 * @param libraryId 823 * @param libraryId
824 * @param debuggingEnabled 824 * @param debuggingEnabled
825 * @throws IOException 825 * @throws IOException
826 */ 826 */
827 public void setLibraryProperties(VmIsolate isolate, int libraryId, boolean deb uggingEnabled) 827 public void setLibraryProperties(VmIsolate isolate, int libraryId, boolean deb uggingEnabled)
828 throws IOException { 828 throws IOException {
829 // TODO(scheglov) commented out on 2014-09-25 829 // TODO(scheglov) commented out on 2014-09-25
830 // I still can step into SDK libraries without it. 830 // I still can step into SDK libraries without it.
831 // And with it VM sometimes ignores "resume" command and application just ha ngs. 831 // And with it VM sometimes ignores "resume" command and application just ha ngs.
832 // try { 832 try {
833 // JSONObject request = new JSONObject(); 833 JSONObject request = new JSONObject();
834 // 834
devoncarew 2014/11/25 18:27:35 Commented this back in; w/o it we can't step into
835 // request.put("command", "setLibraryProperties"); 835 request.put("command", "setLibraryProperties");
836 // request.put( 836 request.put(
837 // "params", 837 "params",
838 // new JSONObject().put("libraryId", libraryId).put( 838 new JSONObject().put("libraryId", libraryId).put(
839 // "debuggingEnabled", 839 "debuggingEnabled",
840 // Boolean.toString(debuggingEnabled))); 840 Boolean.toString(debuggingEnabled)));
841 // 841
842 // sendRequest(request, isolate.getId(), null); 842 sendRequest(request, isolate.getId(), null);
843 // } catch (JSONException exception) { 843 } catch (JSONException exception) {
844 // throw new IOException(exception); 844 throw new IOException(exception);
845 // } 845 }
846 } 846 }
847 847
848 /** 848 /**
849 * Set the VM to pause on exceptions. 849 * Set the VM to pause on exceptions.
850 * 850 *
851 * @param isolate 851 * @param isolate
852 * @param kind 852 * @param kind
853 * @throws IOException 853 * @throws IOException
854 */ 854 */
855 public void setPauseOnException(VmIsolate isolate, BreakOnExceptionsType kind) throws IOException { 855 public void setPauseOnException(VmIsolate isolate, BreakOnExceptionsType kind) throws IOException {
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1523 } 1523 }
1524 } 1524 }
1525 }); 1525 });
1526 } catch (IOException e) { 1526 } catch (IOException e) {
1527 throw new JSONException(e); 1527 throw new JSONException(e);
1528 } 1528 }
1529 } 1529 }
1530 } 1530 }
1531 1531
1532 } 1532 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698