Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 752233002: Revert "Use scratch keys for stencil buffers." (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert "Use scratch keys for stencil buffers." This reverts commit 91175f19664a62851da4ca4e0984a7c7c45b258f. Revert "Cleanup res cache bench and split out into a unit test." This reverts commit 4e4303f002c5958c6c958e7ba8e49b24c25f0b22. Revert "rebaselines" This reverts commit 65ba7b57759bfca60b24bc34dc46fc8caaf146f0. TBR=tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/19cd0f1813c4050e7604e1c5b9b5c7ca3de85e7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -131 lines) Patch
M bench/GrResourceCacheBench.cpp View 3 chunks +156 lines, -37 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 2 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrContext.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 2 chunks +0 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752233002/1
6 years ago (2014-11-24 20:03:54 UTC) #2
commit-bot: I haz the power
6 years ago (2014-11-24 20:19:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19cd0f1813c4050e7604e1c5b9b5c7ca3de85e7b

Powered by Google App Engine
This is Rietveld 408576698