Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 749903003: some cleanup around GrGpu/GrDrawTarget copySurface (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@isSameAs
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tiny cleanup #

Patch Set 3 : fix warning #

Patch Set 4 : fix regression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -189 lines) Patch
M src/gpu/GrDrawTarget.h View 1 2 6 chunks +55 lines, -29 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 3 chunks +15 lines, -11 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 2 chunks +13 lines, -12 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 chunks +18 lines, -21 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 1 chunk +9 lines, -14 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +60 lines, -68 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 2 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bsalomon
I'm trying to implement a new subclass of GrDrawTarget and don't want to reimplement all ...
6 years ago (2014-11-25 19:52:24 UTC) #2
joshualitt
On 2014/11/25 19:52:24, bsalomon wrote: > I'm trying to implement a new subclass of GrDrawTarget ...
6 years ago (2014-11-25 20:07:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749903003/20001
6 years ago (2014-11-25 20:12:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/873)
6 years ago (2014-11-25 20:13:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749903003/40001
6 years ago (2014-11-26 14:34:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e9aa5dc4d5906788eaf691d7c69f1494928f401d
6 years ago (2014-11-26 16:45:34 UTC) #10
bsalomon
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/763593002/ by bsalomon@google.com. ...
6 years ago (2014-11-26 18:19:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749903003/60001
6 years ago (2014-11-26 20:18:25 UTC) #13
commit-bot: I haz the power
6 years ago (2014-11-26 20:28:05 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f90a02b42ac7a1ed59460760c6ce03f6f975f22b

Powered by Google App Engine
This is Rietveld 408576698