Plumbing for frame-specific WebWidgets

Plumbing for frame-specific WebWidgets

In preparation for having WebWidgets attached to WebFrames that can be
used instead of WebViewImpl, there are some ChromeClient calls that need
to be generalized. Specifically:
 - attaching root graphics layers has to go through the correct WebWidget
 - scheduleAnimation has to have a frame-specific version

BUG=419087
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186447

[kenrb, 2014-11-24 22:06:40]

kenrb@chromium.org changed reviewers:
+ dcheng@chromium.org, japhet@chromium.org

[kenrb, 2014-11-24 22:06:40]

kenrb@chromium.org changed required reviewers:
+ dcheng@chromium.org, japhet@chromium.org

[kenrb, 2014-11-24 22:07:42]

Nate and Daniel, PTAL?

This is splitting out the blink/core plumbing portions of this patch
https://codereview.chromium.org/638003004/.

[dcheng, 2014-11-24 22:30:37]

dcheng@chromium.org changed required reviewers:
- dcheng@chromium.org, japhet@chromium.org

[dcheng, 2014-11-24 22:30:39]

Some initial thoughts. My main concerns are about the long-term
maintainability--will we be able to clean up/remove the old webview-specific
overloads as we progress?

https://codereview.chromium.org/749333002/diff/20001/Source/core/loader/Frame...
File Source/core/loader/FrameLoaderClient.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/loader/Frame...
Source/core/loader/FrameLoaderClient.h:231: virtual void
attachRootGraphicsLayer(GraphicsLayer*) { }
Is this actually being used? It looks like we're just using ChromeClient in this
patch.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome.cpp
File Source/core/page/Chrome.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome....
Source/core/page/Chrome.cpp:375: void
Chrome::scheduleAnimationForFrame(LocalFrame* rootFrame)
Is rootFrame a local root? We should try to use consistent terminology.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome.h
File Source/core/page/Chrome.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome....
Source/core/page/Chrome.h:71: void scheduleAnimationForFrame(LocalFrame*
rootFrame);
How come this doesn't need to be a virtual on HostWindow like
scheduleAnimation()? Are we going to get rid of the no-argument version in the
long run? It seems like it'd be easier if we didn't have to sometimes work with
WebView and sometimes with WebFrame.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:183: // LocalFrame sets the graphics layer to
that frame's WebWidget, and should be 0
s/to that/for that/

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:184: // for setting the graphics layer to a
WebView or WebPopupView.
We don't seem to actually pass null for the LocalFrame argument right now. Given
that, I don't understand the second part of this comment.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:78: if (rootFrame && !rootFrame->isMainFrame()
&& rootFrame->isLocalRoot()) {
Shouldn't we be able to assert rootFrame->isLocalRoot() if rootFrame isn't null?
Also, how hard would it be to get rid of this default arg and make sure we're
passing in the local root? I see just a few calls to this function in
Document/FrameSelection/RenderObject, and it's not clear to me that using the
main frame by default is actually correct.

[kenrb, 2014-11-25 17:14:56]

The bug talks about the eventual plan for this. When we remove much of the
handling code from WebViewImpl, it will force cleanup of the places where we
currently have 2 paths.

https://codereview.chromium.org/749333002/diff/20001/Source/core/loader/Frame...
File Source/core/loader/FrameLoaderClient.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/loader/Frame...
Source/core/loader/FrameLoaderClient.h:231: virtual void
attachRootGraphicsLayer(GraphicsLayer*) { }
On 2014/11/24 22:30:38, dcheng wrote:
> Is this actually being used? It looks like we're just using ChromeClient in
this
> patch.

Correct, this was an oversight. I had originally tried routing this call through
FrameLoaderClient but it broke popups. Fixed in current patch.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome.cpp
File Source/core/page/Chrome.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome....
Source/core/page/Chrome.cpp:375: void
Chrome::scheduleAnimationForFrame(LocalFrame* rootFrame)
On 2014/11/24 22:30:38, dcheng wrote:
> Is rootFrame a local root? We should try to use consistent terminology.

Changed.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome.h
File Source/core/page/Chrome.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/Chrome....
Source/core/page/Chrome.h:71: void scheduleAnimationForFrame(LocalFrame*
rootFrame);
On 2014/11/24 22:30:39, dcheng wrote:
> How come this doesn't need to be a virtual on HostWindow like
> scheduleAnimation()? Are we going to get rid of the no-argument version in the
> long run? It seems like it'd be easier if we didn't have to sometimes work
with
> WebView and sometimes with WebFrame.

For WebView vs WebFrame, the goal is to strip most of this code out of WebView
as soon as we are able to use a WebFrameWidget on the top-level frame.

I don't know yet what needs to be done with HostWindow. We will have to revisit
this code later, in any case.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:183: // LocalFrame sets the graphics layer to
that frame's WebWidget, and should be 0
On 2014/11/24 22:30:39, dcheng wrote:
> s/to that/for that/

Done.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:184: // for setting the graphics layer to a
WebView or WebPopupView.
On 2014/11/24 22:30:39, dcheng wrote:
> We don't seem to actually pass null for the LocalFrame argument right now.
Given
> that, I don't understand the second part of this comment.

Changed.

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:78: if (rootFrame && !rootFrame->isMainFrame()
&& rootFrame->isLocalRoot()) {
On 2014/11/24 22:30:39, dcheng wrote:
> Shouldn't we be able to assert rootFrame->isLocalRoot() if rootFrame isn't
null?
> Also, how hard would it be to get rid of this default arg and make sure we're
> passing in the local root? I see just a few calls to this function in
> Document/FrameSelection/RenderObject, and it's not clear to me that using the
> main frame by default is actually correct.

This goes to the WebViewImpl by default, which preserves existing behavior when
the main frame is local. For correct behavior with OOPIFs, PageAnimator needs to
be refactored.

[dcheng, 2014-11-25 20:05:13]

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:78: if (rootFrame && !rootFrame->isMainFrame()
&& rootFrame->isLocalRoot()) {
On 2014/11/25 17:14:56, kenrb wrote:
> On 2014/11/24 22:30:39, dcheng wrote:
> > Shouldn't we be able to assert rootFrame->isLocalRoot() if rootFrame isn't
> null?
> > Also, how hard would it be to get rid of this default arg and make sure
we're
> > passing in the local root? I see just a few calls to this function in
> > Document/FrameSelection/RenderObject, and it's not clear to me that using
the
> > main frame by default is actually correct.
> 
> This goes to the WebViewImpl by default, which preserves existing behavior
when
> the main frame is local. For correct behavior with OOPIFs, PageAnimator needs
to
> be refactored.

OK, can we still add an assert like ASSERT(!rootFrame ||
rootFrame->isLocalRoot())?

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:144: virtual void
scheduleAnimationForFrame(LocalFrame* rootFrame) { }
Ditto for naming consistency, here and elsewhere.

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
LocalFrame here should be a local root as well, right?

[kenrb, 2014-11-26 16:17:12]

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/20001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:78: if (rootFrame && !rootFrame->isMainFrame()
&& rootFrame->isLocalRoot()) {
On 2014/11/25 20:05:13, dcheng wrote:
> On 2014/11/25 17:14:56, kenrb wrote:
> > On 2014/11/24 22:30:39, dcheng wrote:
> > > Shouldn't we be able to assert rootFrame->isLocalRoot() if rootFrame isn't
> > null?
> > > Also, how hard would it be to get rid of this default arg and make sure
> we're
> > > passing in the local root? I see just a few calls to this function in
> > > Document/FrameSelection/RenderObject, and it's not clear to me that using
> the
> > > main frame by default is actually correct.
> > 
> > This goes to the WebViewImpl by default, which preserves existing behavior
> when
> > the main frame is local. For correct behavior with OOPIFs, PageAnimator
needs
> to
> > be refactored.
> 
> OK, can we still add an assert like ASSERT(!rootFrame ||
> rootFrame->isLocalRoot())?

No, it is called with non-root frames often. In that case it would probably be
more correct to find the local root and calling scheduleAnimationForFrame on
that, but since there is a FIXME and I am not sure how PageAnimator is going to
end up looking when mainFrame is remote, I have left it simpler for now.

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:144: virtual void
scheduleAnimationForFrame(LocalFrame* rootFrame) { }
On 2014/11/25 20:05:13, dcheng wrote:
> Ditto for naming consistency, here and elsewhere.

Removed the name here.

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
On 2014/11/25 20:05:13, dcheng wrote:
> LocalFrame here should be a local root as well, right?

I think the comment is sufficient. The important thing is that the frame has a
WebWidget.

[dcheng, 2014-11-26 16:27:13]

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
On 2014/11/26 16:17:11, kenrb wrote:
> On 2014/11/25 20:05:13, dcheng wrote:
> > LocalFrame here should be a local root as well, right?
> 
> I think the comment is sufficient. The important thing is that the frame has a
> WebWidget.

I think it's actually important to say "localRoot" or "localFrameRoot" here
(whatever we decide our terminology is going to be). If I just saw LocalFrame*
in the signature, it would seem reasonable (but incorrect) to assume I can pass
any LocalFrame. If you have to explain when LocalFrame has a WebWidget, you may
as well just put it directly in the name.

Unrelated: We should probably make isLocalRoot and
localFrameRoot()/localFrameRootTemporary() consistently named as well.
Personally, I think it's fine to just call it localRoot; since it always appears
with the type LocalFrame*, "frame" in the name is redundant.

[kenrb, 2014-11-26 17:31:17]

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/40001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
On 2014/11/26 16:27:13, dcheng wrote:
> On 2014/11/26 16:17:11, kenrb wrote:
> > On 2014/11/25 20:05:13, dcheng wrote:
> > > LocalFrame here should be a local root as well, right?
> > 
> > I think the comment is sufficient. The important thing is that the frame has
a
> > WebWidget.
> 
> I think it's actually important to say "localRoot" or "localFrameRoot" here
> (whatever we decide our terminology is going to be). If I just saw LocalFrame*
> in the signature, it would seem reasonable (but incorrect) to assume I can
pass
> any LocalFrame. If you have to explain when LocalFrame has a WebWidget, you
may
> as well just put it directly in the name.
> 
> Unrelated: We should probably make isLocalRoot and
> localFrameRoot()/localFrameRootTemporary() consistently named as well.
> Personally, I think it's fine to just call it localRoot; since it always
appears
> with the type LocalFrame*, "frame" in the name is redundant.

That is reasonable, but could be done as an independent rename CL.

[dcheng, 2014-11-26 18:20:00]

LGTM with comments addressed.

IMO, we should just go with localRoot, since we already have isLocalRoot(). It's
simple enough to rename the other ones in a separate patch; may as well save
ourselves some work down the road.

https://codereview.chromium.org/749333002/diff/80001/Source/core/loader/Empty...
File Source/core/loader/EmptyClients.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/loader/Empty...
Source/core/loader/EmptyClients.h:154: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) override { }
LocalFrame* localRoot.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome.cpp
File Source/core/page/Chrome.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome....
Source/core/page/Chrome.cpp:375: void
Chrome::scheduleAnimationForFrame(LocalFrame* localFrameRoot)
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome.h
File Source/core/page/Chrome.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome....
Source/core/page/Chrome.h:71: void scheduleAnimationForFrame(LocalFrame*
localFrameRoot);
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localFrameRoot) = 0;
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:69: void
PageAnimator::scheduleVisualUpdate(LocalFrame* rootFrame)
And then just call this frame--it's a bit confusing to call this rootFrame when
it's not always a local root.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:69: void
PageAnimator::scheduleVisualUpdate(LocalFrame* rootFrame)
And then just call this frame--it's a bit confusing to call this rootFrame when
it's not always a local root.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
Source/core/page/PageAnimator.h:19: void scheduleVisualUpdate(LocalFrame*
rootFrame = 0);
This one is weird to me, because it's apparently called with non root frames a
lot. It seems like this will be addressed in the long term. In the meantime,
maybe it's best to omit the name for this one.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.cpp:495: void
ChromeClientImpl::scheduleAnimationForFrame(LocalFrame* localFrameRoot)
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.cpp:699: void
ChromeClientImpl::attachRootGraphicsLayer(GraphicsLayer* rootLayer, LocalFrame*
frame)
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
File Source/web/ChromeClientImpl.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.h:115: virtual void
scheduleAnimationForFrame(LocalFrame* localFrameRoot) override;
LocalFrame* localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.h:139: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) override;
localRoot

https://codereview.chromium.org/749333002/diff/80001/Source/web/WebPagePopupI...
File Source/web/WebPagePopupImpl.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/WebPagePopupI...
Source/web/WebPagePopupImpl.cpp:164: virtual void
attachRootGraphicsLayer(GraphicsLayer* graphicsLayer, LocalFrame* frame)
override
localRoot

[kenrb, 2014-12-02 17:49:42]

kenrb@chromium.org changed reviewers:
+ dglazkov@chromium.org

[kenrb, 2014-12-02 17:49:42]

kenrb@chromium.org changed required reviewers:
+ dglazkov@chromium.org

[kenrb, 2014-12-02 17:49:44]

Dimitri: This needs review from a Source/web owner. Are you able to help out
here?

https://codereview.chromium.org/749333002/diff/80001/Source/core/loader/Empty...
File Source/core/loader/EmptyClients.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/loader/Empty...
Source/core/loader/EmptyClients.h:154: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) override { }
On 2014/11/26 18:19:59, dcheng wrote:
> LocalFrame* localRoot.

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome.cpp
File Source/core/page/Chrome.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome....
Source/core/page/Chrome.cpp:375: void
Chrome::scheduleAnimationForFrame(LocalFrame* localFrameRoot)
On 2014/11/26 18:19:59, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome.h
File Source/core/page/Chrome.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/Chrome....
Source/core/page/Chrome.h:71: void scheduleAnimationForFrame(LocalFrame*
localFrameRoot);
On 2014/11/26 18:19:59, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/ChromeC...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/ChromeC...
Source/core/page/ChromeClient.h:185: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localFrameRoot) = 0;
On 2014/11/26 18:20:00, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
Source/core/page/PageAnimator.cpp:69: void
PageAnimator::scheduleVisualUpdate(LocalFrame* rootFrame)
On 2014/11/26 18:20:00, dcheng wrote:
> And then just call this frame--it's a bit confusing to call this rootFrame
when
> it's not always a local root.

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
File Source/core/page/PageAnimator.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/core/page/PageAni...
Source/core/page/PageAnimator.h:19: void scheduleVisualUpdate(LocalFrame*
rootFrame = 0);
On 2014/11/26 18:20:00, dcheng wrote:
> This one is weird to me, because it's apparently called with non root frames a
> lot. It seems like this will be addressed in the long term. In the meantime,
> maybe it's best to omit the name for this one.

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.cpp:495: void
ChromeClientImpl::scheduleAnimationForFrame(LocalFrame* localFrameRoot)
On 2014/11/26 18:20:00, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.cpp:699: void
ChromeClientImpl::attachRootGraphicsLayer(GraphicsLayer* rootLayer, LocalFrame*
frame)
On 2014/11/26 18:20:00, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
File Source/web/ChromeClientImpl.h (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.h:115: virtual void
scheduleAnimationForFrame(LocalFrame* localFrameRoot) override;
On 2014/11/26 18:20:00, dcheng wrote:
> LocalFrame* localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.h:115: virtual void
scheduleAnimationForFrame(LocalFrame* localFrameRoot) override;
On 2014/11/26 18:20:00, dcheng wrote:
> LocalFrame* localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/ChromeClientI...
Source/web/ChromeClientImpl.h:139: virtual void
attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) override;
On 2014/11/26 18:20:00, dcheng wrote:
> localRoot

Done.

https://codereview.chromium.org/749333002/diff/80001/Source/web/WebPagePopupI...
File Source/web/WebPagePopupImpl.cpp (right):

https://codereview.chromium.org/749333002/diff/80001/Source/web/WebPagePopupI...
Source/web/WebPagePopupImpl.cpp:164: virtual void
attachRootGraphicsLayer(GraphicsLayer* graphicsLayer, LocalFrame* frame)
override
On 2014/11/26 18:20:00, dcheng wrote:
> localRoot

Done.

[dglazkov, 2014-12-03 16:50:02]

dglazkov@chromium.org changed required reviewers:
- dglazkov@chromium.org

[dglazkov, 2014-12-03 16:50:03]

Source/web lgtm.

[kenrb, 2014-12-03 16:56:11]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-12-03 16:56:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/749333002/100001

[commit-bot: I haz the power, 2014-12-03 17:02:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 17:02:02]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[kenrb, 2014-12-03 18:15:59]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-12-03 18:17:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/749333002/120001

[commit-bot: I haz the power, 2014-12-03 19:42:35]

Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186447