Plumbing for frame-specific WebWidgets

Source/core/page/ChromeClient.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 123 matching lines @@
 
     // Methods used by HostWindow.
     virtual void invalidateContentsAndRootView(const IntRect&) = 0;
     virtual void invalidateContentsForSlowScroll(const IntRect&) = 0;
     virtual IntRect rootViewToScreen(const IntRect&) const = 0;
     virtual blink::WebScreenInfo screenInfo() const = 0;
     virtual void setCursor(const Cursor&) = 0;
     virtual void scheduleAnimation() = 0;
     // End methods used by HostWindow.
 
+    virtual void scheduleAnimationForFrame(LocalFrame* rootFrame) { }
+
     virtual void dispatchViewportPropertiesDidChange(const ViewportDescription&) const { }
 
     virtual void contentsSizeChanged(LocalFrame*, const IntSize&) const = 0;
     virtual void deviceOrPageScaleFactorChanged() const { }
     virtual void layoutUpdated(LocalFrame*) const { }
 
     virtual void mouseDidMoveOverElement(const HitTestResult&, unsigned modifierFlags) = 0;
 
     virtual void setToolTip(const String&, TextDirection) = 0;
 
@@ skipping 16 matching lines @@
     virtual void openTextDataListChooser(HTMLInputElement&) = 0;
 
     virtual void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) = 0;
 
     // Asychronous request to enumerate all files in a directory chosen by the user.
     virtual void enumerateChosenDirectory(FileChooser*) = 0;
 
     // Allows ports to customize the type of graphics layers created by this page.
     virtual GraphicsLayerFactory* graphicsLayerFactory() const { return nullptr; }
 
-    // Pass 0 as the GraphicsLayer to detatch the root layer.
-    virtual void attachRootGraphicsLayer(GraphicsLayer*) = 0;
+    // Pass 0 as the GraphicsLayer to detach the root layer.
+    // LocalFrame sets the graphics layer to that frame's WebWidget, and should be 0

[dcheng, 2014/11/24 22:30:39]

s/to that/for that/

[kenrb, 2014/11/25 17:14:56]

Done.

+    // for setting the graphics layer to a WebView or WebPopupView.

[dcheng, 2014/11/24 22:30:39]

We don't seem to actually pass null for the LocalFrame argument right now. Given
that, I don't understand the second part of this comment.

[kenrb, 2014/11/25 17:14:56]

Changed.

+    virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
 
     virtual void enterFullScreenForElement(Element*) { }
     virtual void exitFullScreenForElement(Element*) { }
 
     virtual void clearCompositedSelectionBounds() { }
     virtual void updateCompositedSelectionBounds(const CompositedSelectionBound& anchor, const CompositedSelectionBound& focus) { }
 
     virtual void needTouchEvents(bool) = 0;
 
     virtual void setTouchAction(TouchAction) = 0;
@@ skipping 38 matching lines @@
     virtual void didUpdateTextOfFocusedElementByNonUserInput() { }
     virtual void showImeIfNeeded() { }
 
 protected:
     virtual ~ChromeClient() { }
 };
 
 } // namespace blink
 
 #endif // ChromeClient_h