Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: Source/core/page/PageAnimator.cpp

Issue 749333002: Plumbing for frame-specific WebWidgets (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PageAnimator.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/PageAnimator.cpp
diff --git a/Source/core/page/PageAnimator.cpp b/Source/core/page/PageAnimator.cpp
index 0d429bae2ab329236e0351c91e2c33213606c226..4a1e2837db6cf382dfb6fb4394cfc16708e9c6f4 100644
--- a/Source/core/page/PageAnimator.cpp
+++ b/Source/core/page/PageAnimator.cpp
@@ -66,12 +66,20 @@ void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
documents[i]->serviceScriptedAnimations(monotonicAnimationStartTime);
}
-void PageAnimator::scheduleVisualUpdate()
+void PageAnimator::scheduleVisualUpdate(LocalFrame* frame)
{
// FIXME: also include m_animationFramePending here. It is currently not there due to crbug.com/353756.
if (m_servicingAnimations || m_updatingLayoutAndStyleForPainting)
return;
- m_page->chrome().scheduleAnimation();
+ // FIXME: The frame-specific version of scheduleAnimation() is for
+ // out-of-process iframes. Passing 0 or the top-level frame to this method
+ // causes scheduleAnimation() to be called for the page, which still uses
+ // a page-level WebWidget (the WebViewImpl).
+ if (frame && !frame->isMainFrame() && frame->isLocalRoot()) {
+ m_page->chrome().scheduleAnimationForFrame(frame);
+ } else {
+ m_page->chrome().scheduleAnimation();
+ }
}
void PageAnimator::updateLayoutAndStyleForPainting(LocalFrame* rootFrame)
« no previous file with comments | « Source/core/page/PageAnimator.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698