Plumbing for frame-specific WebWidgets

Source/core/page/PageAnimator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/page/PageAnimator.h"
 
 #include "core/animation/DocumentAnimations.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 48 matching lines @@
 
     for (size_t i = 0; i < documents.size(); ++i) {
         DocumentAnimations::updateAnimationTimingForAnimationFrame(*documents[i], monotonicAnimationStartTime);
         SVGDocumentExtensions::serviceOnAnimationFrame(*documents[i], monotonicAnimationStartTime);
     }
 
     for (size_t i = 0; i < documents.size(); ++i)
         documents[i]->serviceScriptedAnimations(monotonicAnimationStartTime);
 }
 
-void PageAnimator::scheduleVisualUpdate()
+void PageAnimator::scheduleVisualUpdate(LocalFrame* rootFrame)

[dcheng, 2014/11/26 18:20:00]

And then just call this frame--it's a bit confusing to call this rootFrame when
it's not always a local root.

[dcheng, 2014/11/26 18:20:00]

And then just call this frame--it's a bit confusing to call this rootFrame when
it's not always a local root.

[kenrb, 2014/12/02 17:49:43]

Done.

 {
     // FIXME: also include m_animationFramePending here. It is currently not there due to crbug.com/353756.
     if (m_servicingAnimations || m_updatingLayoutAndStyleForPainting)
         return;
-    m_page->chrome().scheduleAnimation();
+    // FIXME: The frame-specific version of scheduleAnimation() is for
+    // out-of-process iframes. Passing 0 or the top-level frame to this method
+    // causes scheduleAnimation() to be called for the page, which still uses
+    // a page-level WebWidget (the WebViewImpl).
+    if (rootFrame && !rootFrame->isMainFrame() && rootFrame->isLocalRoot()) {
+        m_page->chrome().scheduleAnimationForFrame(rootFrame);
+    } else {
+        m_page->chrome().scheduleAnimation();
+    }
 }
 
 void PageAnimator::updateLayoutAndStyleForPainting(LocalFrame* rootFrame)
 {
     RefPtrWillBeRawPtr<FrameView> view = rootFrame->view();
 
     TemporaryChange<bool> servicing(m_updatingLayoutAndStyleForPainting, true);
 
     // In order for our child HWNDs (NativeWindowWidgets) to update properly,
     // they need to be told that we are updating the screen. The problem is that
     // the native widgets need to recalculate their clip region and not overlap
     // any of our non-native widgets. To force the resizing, call
     // setFrameRect(). This will be a quick operation for most frames, but the
     // NativeWindowWidgets will update a proper clipping region.
     view->setFrameRect(view->frameRect());
 
     // setFrameRect may have the side-effect of causing existing page layout to
     // be invalidated, so layout needs to be called last.
     view->updateLayoutAndStyleForPainting();
 }
 
 }