Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 749333002: Plumbing for frame-specific WebWidgets (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Argument name change Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 virtual void needTouchEvents(bool needsTouchEvents) override 154 virtual void needTouchEvents(bool needsTouchEvents) override
155 { 155 {
156 m_popup->widgetClient()->hasTouchEventHandlers(needsTouchEvents); 156 m_popup->widgetClient()->hasTouchEventHandlers(needsTouchEvents);
157 } 157 }
158 158
159 virtual GraphicsLayerFactory* graphicsLayerFactory() const override 159 virtual GraphicsLayerFactory* graphicsLayerFactory() const override
160 { 160 {
161 return m_popup->m_webView->graphicsLayerFactory(); 161 return m_popup->m_webView->graphicsLayerFactory();
162 } 162 }
163 163
164 virtual void attachRootGraphicsLayer(GraphicsLayer* graphicsLayer) override 164 virtual void attachRootGraphicsLayer(GraphicsLayer* graphicsLayer, LocalFram e* frame) override
dcheng 2014/11/26 18:20:00 localRoot
kenrb 2014/12/02 17:49:43 Done.
165 { 165 {
166 m_popup->setRootGraphicsLayer(graphicsLayer); 166 m_popup->setRootGraphicsLayer(graphicsLayer);
167 } 167 }
168 168
169 virtual void postAccessibilityNotification(AXObject* obj, AXObjectCache::AXN otification notification) override 169 virtual void postAccessibilityNotification(AXObject* obj, AXObjectCache::AXN otification notification) override
170 { 170 {
171 WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(m_popup->m_popup Client->ownerElement().document().frame()); 171 WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(m_popup->m_popup Client->ownerElement().document().frame());
172 if (obj && frame && frame->client()) 172 if (obj && frame && frame->client())
173 frame->client()->postAccessibilityEvent(WebAXObject(obj), static_cas t<WebAXEvent>(notification)); 173 frame->client()->postAccessibilityEvent(WebAXObject(obj), static_cas t<WebAXEvent>(notification));
174 174
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 // A WebPagePopupImpl instance usually has two references. 464 // A WebPagePopupImpl instance usually has two references.
465 // - One owned by the instance itself. It represents the visible widget. 465 // - One owned by the instance itself. It represents the visible widget.
466 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 466 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
467 // WebPagePopupImpl to close. 467 // WebPagePopupImpl to close.
468 // We need them because the closing operation is asynchronous and the widget 468 // We need them because the closing operation is asynchronous and the widget
469 // can be closed while the WebViewImpl is unaware of it. 469 // can be closed while the WebViewImpl is unaware of it.
470 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 470 return adoptRef(new WebPagePopupImpl(client)).leakRef();
471 } 471 }
472 472
473 } // namespace blink 473 } // namespace blink
OLDNEW
« Source/web/ChromeClientImpl.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698