Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed)

Created:
6 years, 1 month ago by vabr (Chromium)
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PasswordManagerClient::LogSavePasswordProgress should be const This method does not alter the client, only forwards some logs. BUG=432592 Committed: https://crrev.com/c5857466ca83d156f295384a20828b56979f5840 Cr-Commit-Position: refs/heads/master@{#304627}

Patch Set 1 #

Patch Set 2 : Fix tests #

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi Mike, Could you PTAL? Thanks! Vaclav
6 years, 1 month ago (2014-11-18 14:41:25 UTC) #2
Mike West
LGTM
6 years, 1 month ago (2014-11-18 14:48:15 UTC) #3
vabr (Chromium)
Thanks Mike! In patch set 3 I rebased on another CL in flight and marked ...
6 years, 1 month ago (2014-11-18 14:59:09 UTC) #4
vabr (Chromium)
Hmm, so the other CL has troubles landing. I'm deleting patch set 3, and landing ...
6 years, 1 month ago (2014-11-18 16:40:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735733002/20001
6 years, 1 month ago (2014-11-18 16:42:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-18 17:24:10 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 17:24:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5857466ca83d156f295384a20828b56979f5840
Cr-Commit-Position: refs/heads/master@{#304627}

Powered by Google App Engine
This is Rietveld 408576698