Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/password_manager/content/browser/content_credential_manager _dispatcher.h" 10 #include "components/password_manager/content/browser/content_credential_manager _dispatcher.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 void PasswordAutofillWasBlocked( 56 void PasswordAutofillWasBlocked(
57 const autofill::PasswordFormMap& best_matches) const override; 57 const autofill::PasswordFormMap& best_matches) const override;
58 PrefService* GetPrefs() override; 58 PrefService* GetPrefs() override;
59 password_manager::PasswordStore* GetPasswordStore() override; 59 password_manager::PasswordStore* GetPasswordStore() override;
60 password_manager::PasswordManagerDriver* GetDriver() override; 60 password_manager::PasswordManagerDriver* GetDriver() override;
61 base::FieldTrial::Probability GetProbabilityForExperiment( 61 base::FieldTrial::Probability GetProbabilityForExperiment(
62 const std::string& experiment_name) override; 62 const std::string& experiment_name) override;
63 bool IsPasswordSyncEnabled( 63 bool IsPasswordSyncEnabled(
64 password_manager::CustomPassphraseState state) override; 64 password_manager::CustomPassphraseState state) override;
65 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override; 65 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
66 void LogSavePasswordProgress(const std::string& text) override; 66 void LogSavePasswordProgress(const std::string& text) const override;
67 bool IsLoggingActive() const override; 67 bool IsLoggingActive() const override;
68 68
69 // Hides any visible generation UI. 69 // Hides any visible generation UI.
70 void HidePasswordGenerationPopup(); 70 void HidePasswordGenerationPopup();
71 71
72 static void CreateForWebContentsWithAutofillClient( 72 static void CreateForWebContentsWithAutofillClient(
73 content::WebContents* contents, 73 content::WebContents* contents,
74 autofill::AutofillClient* autofill_client); 74 autofill::AutofillClient* autofill_client);
75 75
76 // Convenience method to allow //chrome code easy access to a PasswordManager 76 // Convenience method to allow //chrome code easy access to a PasswordManager
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 AutofillForSyncCredentialsState autofill_sync_state_; 161 AutofillForSyncCredentialsState autofill_sync_state_;
162 162
163 // If the sync credential was filtered during autofill. Used for statistics 163 // If the sync credential was filtered during autofill. Used for statistics
164 // reporting. 164 // reporting.
165 bool sync_credential_was_filtered_; 165 bool sync_credential_was_filtered_;
166 166
167 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 167 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
168 }; 168 };
169 169
170 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 170 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698