components/password_manager/core/browser/password_manager_client.h - Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc ('k') | components/password_manager/core/browser/password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index c265419edb6a0da61a6f3972e79aefe388c26b46..4bef91fb3fd4e2911b55e53ad4cb70f30e2b86b5 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -108,7 +108,7 @@ class PasswordManagerClient {

virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used);

// Forward |text| for display to the LogRouter (if registered with one).

- virtual void LogSavePasswordProgress(const std::string& text);

+ virtual void LogSavePasswordProgress(const std::string& text) const;

// Returns true if logs recorded via LogSavePasswordProgress will be

// displayed, and false otherwise.