components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc - Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/browser_save_password_progress_logger.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

index ba056d2574f0027abbb37d8c36ee4bed01e82d58..1e73070a92dd10c20e3f8e5fbaf0f278850c1067 100644

--- a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

+++ b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

@@ -25,7 +25,7 @@ class TestLogger : public BrowserSavePasswordProgressLogger {

class MockPasswordManagerClient : public StubPasswordManagerClient {

public:

- MOCK_METHOD1(LogSavePasswordProgress, void(const std::string& text));

+ MOCK_CONST_METHOD1(LogSavePasswordProgress, void(const std::string& text));

};

} // namespace