components/password_manager/core/browser/browser_save_password_progress_logger.h - Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger.h

Issue 735733002: PasswordManagerClient::LogSavePasswordProgress should be const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/password_manager/core/browser/browser_save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/browser_save_password_progress_logger.h

diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger.h b/components/password_manager/core/browser/browser_save_password_progress_logger.h

index 883461c4044c255885b994b2315a94009cc220f9..5da7a9d841d76cc476493cff78ef55b782992b5d 100644

--- a/components/password_manager/core/browser/browser_save_password_progress_logger.h

+++ b/components/password_manager/core/browser/browser_save_password_progress_logger.h

@@ -18,7 +18,8 @@ class PasswordManagerClient;

class BrowserSavePasswordProgressLogger

: public autofill::SavePasswordProgressLogger {

public:

- explicit BrowserSavePasswordProgressLogger(PasswordManagerClient* client);

+ explicit BrowserSavePasswordProgressLogger(

+ const PasswordManagerClient* client);

~BrowserSavePasswordProgressLogger() override;

protected:

@@ -28,7 +29,7 @@ class BrowserSavePasswordProgressLogger

private:

// The PasswordManagerClient to which logs can be sent for display. The client

// must outlive this logger.

- PasswordManagerClient* const client_;

+ const PasswordManagerClient* const client_;

DISALLOW_COPY_AND_ASSIGN(BrowserSavePasswordProgressLogger);

};