dstCopy on optdrawstate

dstCopy on optdrawstate

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9176e2c159089458b1e2226a94fab1af0fba32ac

[joshualitt, 2014-11-19 23:10:17]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com, joshualitt@google.com

[joshualitt, 2014-11-19 23:10:18]

straightforward change to move dstcopy to optDrawState.  The nice thing is, this
will make its ultimate removal more straightforward.

I looked into moving draw type to optstate, but this change was not as
straightforward.  I really want the primitivetype on optdrawstate, but this
wouldn't make sense for paths.  Once primitive type is on GP then removing
drawtype all together should be easy.

[egdaniel, 2014-11-20 14:54:51]

lgtm

[bsalomon, 2014-11-20 15:02:28]

This actually seems a little frightening to me... GrOptDrawState now has a
pointer to something it doesn't own.

[bsalomon, 2014-11-20 15:03:24]

On 2014/11/20 15:02:28, bsalomon wrote:
> This actually seems a little frightening to me... GrOptDrawState now has a
> pointer to something it doesn't own.

Oh I see, it's a copy.

[joshualitt, 2014-11-20 15:20:51]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-11-20 15:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/735363003/20001

[commit-bot: I haz the power, 2014-11-20 15:28:57]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9176e2c159089458b1e2226a94fab1af0fba32ac