Make undocked DevTools window invisible to extensions API.

Make undocked DevTools window invisible to extensions API.

BUG=427226
Committed: https://crrev.com/4af3ec98321a5f2f942dfcb52f9e329f18bbd7d7
Cr-Commit-Position: refs/heads/master@{#305440}

[pfeldman, 2014-11-18 14:55:04]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2014-11-18 14:55:05]

lgtm

[not at google - send to devlin, 2014-11-18 15:36:18]

kalman@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-11-18 15:36:18]

Is there an easy way to write a test for this?

[dgozman, 2014-11-19 12:49:21]

Added simple test. PTAL

[dgozman, 2014-11-21 09:55:00]

@kalman: friendly ping.

[not at google - send to devlin, 2014-11-21 21:10:25]

lgtm

[not at google - send to devlin, 2014-11-21 21:10:57]

This makes it hidden from both the chrome.tabs and chrome.windows APIs right?

[dgozman, 2014-11-24 16:26:45]

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/tabs/tabs_api.cc:858: if
(!browser->extension_window_controller()->IsVisibleToExtension(
I had to add a check here for "tabs.query" to ignore DevTools, and now I'm
worried whether this will have side-effect for platform apps.

[not at google - send to devlin, 2014-11-24 16:46:41]

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/tabs/tabs_api.cc:858: if
(!browser->extension_window_controller()->IsVisibleToExtension(
On 2014/11/24 16:26:45, dgozman wrote:
> I had to add a check here for "tabs.query" to ignore DevTools, and now I'm
> worried whether this will have side-effect for platform apps.

This check looks right to me. Do you mean a side-effect of hiding app windows
from extensions? That'd be correct, and I had thought we already did that
somewhere - if we didn't that'd be an odd bug to have stayed around for so long.
Perhaps it's checked somewhere else as well?

[dgozman, 2014-11-24 16:50:39]

Alright, I'm going to land this.

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/734983003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/tabs/tabs_api.cc:858: if
(!browser->extension_window_controller()->IsVisibleToExtension(
On 2014/11/24 16:46:40, kalman wrote:
> On 2014/11/24 16:26:45, dgozman wrote:
> > I had to add a check here for "tabs.query" to ignore DevTools, and now I'm
> > worried whether this will have side-effect for platform apps.
> 
> This check looks right to me. Do you mean a side-effect of hiding app windows
> from extensions? That'd be correct, and I had thought we already did that
> somewhere - if we didn't that'd be an odd bug to have stayed around for so
long.
> Perhaps it's checked somewhere else as well?

Yes, it's checked a few times, for example in WindowGetAll. That's not enough
for DevTools though - need a check here as well.

[dgozman, 2014-11-24 16:50:59]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-11-24 16:52:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/734983003/40001

[commit-bot: I haz the power, 2014-11-24 17:34:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-24 17:36:15]

Patchset 3 (id:??) landed as
https://crrev.com/4af3ec98321a5f2f942dfcb52f9e329f18bbd7d7
Cr-Commit-Position: refs/heads/master@{#305440}