chrome/browser/extensions/browser_extension_window_controller.cc - Issue 734983003: Make undocked DevTools window invisible to extensions API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 734983003: Make undocked DevTools window invisible to extensions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tabs.query Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/browser_extension_window_controller.h"	5 #include "chrome/browser/extensions/browser_extension_window_controller.h"

6	6

7 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"	7 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"

8 #include "chrome/browser/extensions/extension_tab_util.h"	8 #include "chrome/browser/extensions/extension_tab_util.h"

9 #include "chrome/browser/extensions/window_controller_list.h"	9 #include "chrome/browser/extensions/window_controller_list.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 71 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 browser_->ToggleFullscreenModeWithExtension(extension_url);	82 browser_->ToggleFullscreenModeWithExtension(extension_url);

83 }	83 }

84	84

85 Browser* BrowserExtensionWindowController::GetBrowser() const {	85 Browser* BrowserExtensionWindowController::GetBrowser() const {

86 return browser_;	86 return browser_;

87 }	87 }

88	88

89 bool BrowserExtensionWindowController::IsVisibleToExtension(	89 bool BrowserExtensionWindowController::IsVisibleToExtension(

90 const extensions::Extension* extension) const {	90 const extensions::Extension* extension) const {

91 // Platform apps can only see their own windows.	91 // Platform apps can only see their own windows.

92 return !extension->is_platform_app();	92 return !browser_->is_devtools() && !extension->is_platform_app();

93 }	93 }

OLD	NEW