Make undocked DevTools window invisible to extensions API.

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 837 matching lines @@
     Browser* browser = *it;
     if (!GetProfile()->IsSameProfile(browser->profile()))
       continue;
 
     if (!browser->window())
       continue;
 
     if (!include_incognito() && GetProfile() != browser->profile())
       continue;
 
+    if (!browser->extension_window_controller()->IsVisibleToExtension(

[dgozman, 2014/11/24 16:26:45]

I had to add a check here for "tabs.query" to ignore DevTools, and now I'm
worried whether this will have side-effect for platform apps.

[not at google - send to devlin, 2014/11/24 16:46:40]

This check looks right to me. Do you mean a side-effect of hiding app windows
from extensions? That'd be correct, and I had thought we already did that
somewhere - if we didn't that'd be an odd bug to have stayed around for so long.
Perhaps it's checked somewhere else as well?

[dgozman, 2014/11/24 16:50:39]

Yes, it's checked a few times, for example in WindowGetAll. That's not enough
for DevTools though - need a check here as well.

+            extension())) {
+      continue;
+    }
+
     if (window_id >= 0 && window_id != ExtensionTabUtil::GetWindowId(browser))
       continue;
 
     if (window_id == extension_misc::kCurrentWindowId &&
         browser != current_browser) {
       continue;
     }
 
     if (!MatchesBool(params->query_info.current_window.get(),
                      browser == current_browser)) {
@@ skipping 1073 matching lines @@
   ZoomController::ZoomMode zoom_mode = zoom_controller->zoom_mode();
   api::tabs::ZoomSettings zoom_settings;
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions