Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 734983003: Make undocked DevTools window invisible to extensions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tabs.query Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index a51aae4aed21f242784eb21673c4317252373177..b7b9fcc4f344d97c15872f06f546911216050df3 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -855,6 +855,11 @@ bool TabsQueryFunction::RunSync() {
if (!include_incognito() && GetProfile() != browser->profile())
continue;
+ if (!browser->extension_window_controller()->IsVisibleToExtension(
dgozman 2014/11/24 16:26:45 I had to add a check here for "tabs.query" to igno
not at google - send to devlin 2014/11/24 16:46:40 This check looks right to me. Do you mean a side-e
dgozman 2014/11/24 16:50:39 Yes, it's checked a few times, for example in Wind
+ extension())) {
+ continue;
+ }
+
if (window_id >= 0 && window_id != ExtensionTabUtil::GetWindowId(browser))
continue;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698