Make undocked DevTools window invisible to extensions API.

chrome/browser/extensions/api/tabs/tabs_api.cc

Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index a51aae4aed21f242784eb21673c4317252373177..b7b9fcc4f344d97c15872f06f546911216050df3 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -855,6 +855,11 @@ bool TabsQueryFunction::RunSync() {
     if (!include_incognito() && GetProfile() != browser->profile())
       continue;
 
+    if (!browser->extension_window_controller()->IsVisibleToExtension(

[dgozman, 2014/11/24 16:26:45]

I had to add a check here for "tabs.query" to ignore DevTools, and now I'm
worried whether this will have side-effect for platform apps.

[not at google - send to devlin, 2014/11/24 16:46:40]

This check looks right to me. Do you mean a side-effect of hiding app windows
from extensions? That'd be correct, and I had thought we already did that
somewhere - if we didn't that'd be an odd bug to have stayed around for so long.
Perhaps it's checked somewhere else as well?

[dgozman, 2014/11/24 16:50:39]

Yes, it's checked a few times, for example in WindowGetAll. That's not enough
for DevTools though - need a check here as well.

+            extension())) {
+      continue;
+    }
+
     if (window_id >= 0 && window_id != ExtensionTabUtil::GetWindowId(browser))
       continue;