chrome/browser/extensions/browser_extension_window_controller.cc - Issue 734983003: Make undocked DevTools window invisible to extensions API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 734983003: Make undocked DevTools window invisible to extensions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tabs.query Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/browser_extension_window_controller.cc

diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc

index 4ce8e8e00a81a92be55f154b6238746fd0407413..0dc3c08367a093299a71352fc85c87bb84b0b2cc 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.cc

+++ b/chrome/browser/extensions/browser_extension_window_controller.cc

@@ -89,5 +89,5 @@ Browser* BrowserExtensionWindowController::GetBrowser() const {

bool BrowserExtensionWindowController::IsVisibleToExtension(

const extensions::Extension* extension) const {

// Platform apps can only see their own windows.

- return !extension->is_platform_app();

+ return !browser_->is_devtools() && !extension->is_platform_app();

}

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | no next file » | no next file with comments »