Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info. (Closed)

Created:
6 years, 1 month ago by aiolos (Not reviewing)
Modified:
6 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Download archives from the page_set's specified bucket in page_set_archive_info. BUG=434478 Committed: https://crrev.com/9f53699000cf07f07aab14629d5ab3a7b09f6f58 Cr-Commit-Position: refs/heads/master@{#304962}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Making bucket required and updating unittests for that requirement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 1 3 chunks +21 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 2 chunks +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
aiolos (Not reviewing)
6 years, 1 month ago (2014-11-19 23:14:46 UTC) #2
dtu
lgtm nit https://codereview.chromium.org/726373005/diff/1/tools/telemetry/telemetry/page/page_set_archive_info.py File tools/telemetry/telemetry/page/page_set_archive_info.py (right): https://codereview.chromium.org/726373005/diff/1/tools/telemetry/telemetry/page/page_set_archive_info.py#newcode16 tools/telemetry/telemetry/page/page_set_archive_info.py:16: def __init__(self, file_path, data, bucket=None, ignore_archive=False): Can ...
6 years, 1 month ago (2014-11-19 23:44:10 UTC) #3
aiolos (Not reviewing)
https://codereview.chromium.org/726373005/diff/1/tools/telemetry/telemetry/page/page_set_archive_info.py File tools/telemetry/telemetry/page/page_set_archive_info.py (right): https://codereview.chromium.org/726373005/diff/1/tools/telemetry/telemetry/page/page_set_archive_info.py#newcode16 tools/telemetry/telemetry/page/page_set_archive_info.py:16: def __init__(self, file_path, data, bucket=None, ignore_archive=False): On 2014/11/19 23:44:10, ...
6 years, 1 month ago (2014-11-20 00:31:30 UTC) #4
dtu
lgtm
6 years, 1 month ago (2014-11-20 01:28:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726373005/20001
6 years, 1 month ago (2014-11-20 01:29:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 03:40:22 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 03:40:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f53699000cf07f07aab14629d5ab3a7b09f6f58
Cr-Commit-Position: refs/heads/master@{#304962}

Powered by Google App Engine
This is Rietveld 408576698