tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py - Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making bucket required and updating unittests for that requirement. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

index c39e22118d3685d547c7bcaba25a91d23213be41..e2f0a06b6fa1103800e6f6ac90db002d88adfbdd 100644

--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

@@ -31,7 +31,7 @@ class PageSetSmokeTest(unittest.TestCase):

page_set.file_path)

wpr_archive_info = page_set_archive_info.PageSetArchiveInfo.FromFile(

- archive_data_file_path, ignore_archive=True)

+ archive_data_file_path, page_set.bucket, ignore_archive=True)

for page in page_set.pages:

if not page.url.startswith('http'):

continue

« no previous file with comments | « tools/telemetry/telemetry/page/page_test_unittest.py ('k') | no next file » | no next file with comments »