tools/telemetry/telemetry/page/page_set.py - Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making bucket required and updating unittests for that requirement. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_set.py

diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py

index bb58e9ed84f6e7763276a16e29103e88fbef8984..682f06966293a437533f822a2732eca920a3b888 100644

--- a/tools/telemetry/telemetry/page/page_set.py

+++ b/tools/telemetry/telemetry/page/page_set.py

@@ -89,7 +89,7 @@ class PageSet(user_story_set.UserStorySet):

if self.archive_data_file and not self._wpr_archive_info:

self._wpr_archive_info = (

page_set_archive_info.PageSetArchiveInfo.FromFile(

- os.path.join(self.base_dir, self.archive_data_file)))

+ os.path.join(self.base_dir, self.archive_data_file), self._bucket))

return self._wpr_archive_info

@property

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_archive_info.py » ('j') | no next file with comments »