tools/telemetry/telemetry/page/page_test_unittest.py - Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_unittest.py

Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making bucket required and updating unittests for that requirement. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_set_archive_info_unittest.py ('k') | tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_test_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_test_unittest.py b/tools/telemetry/telemetry/page/page_test_unittest.py

index 665754886aea7f1e1eb87b05b404079cf043359a..61053618fc0313ed50e611e74bc3077f34258c7f 100644

--- a/tools/telemetry/telemetry/page/page_test_unittest.py

+++ b/tools/telemetry/telemetry/page/page_test_unittest.py

@@ -110,8 +110,8 @@ class PageTestUnitTest(page_test_test_case.PageTestTestCase):

self._options.browser_options.wpr_mode = wpr_modes.WPR_RECORD

ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(

- '', '', json.loads(archive_info_template %

- (test_archive, google_url)))

+ '', '', ps.bucket, json.loads(archive_info_template %

+ (test_archive, google_url)))

ps.pages = [page_module.Page(google_url, ps)]

all_results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals(0, len(all_results.failures))

@@ -120,14 +120,15 @@ class PageTestUnitTest(page_test_test_case.PageTestTestCase):

self._options.browser_options.wpr_mode = wpr_modes.WPR_REPLAY

ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(

- '', '', json.loads(archive_info_template % (test_archive, foo_url)))

+ '', '', ps.bucket, json.loads(archive_info_template %

+ (test_archive, foo_url)))

ps.pages = [page_module.Page(foo_url, ps)]

all_results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals(1, len(all_results.failures))

ps.wpr_archive_info = page_set_archive_info.PageSetArchiveInfo(

- '', '', json.loads(archive_info_template %

- (test_archive, google_url)))

+ '', '', ps.bucket, json.loads(archive_info_template %

+ (test_archive, google_url)))

ps.pages = [page_module.Page(google_url, ps)]

all_results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals(0, len(all_results.failures))