tools/telemetry/telemetry/page/page_set_archive_info_unittest.py - Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set_archive_info_unittest.py

Issue 726373005: Download archives from the page_set's specified bucket in page_set_archive_info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making bucket required and updating unittests for that requirement. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_set_archive_info.py ('k') | tools/telemetry/telemetry/page/page_test_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_set_archive_info_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_set_archive_info_unittest.py b/tools/telemetry/telemetry/page/page_set_archive_info_unittest.py

index 1ee68a19aa15d2d1d8340b0bf2a887efdaa78b59..bcb48370192f42e70ee3c5e9acc022ccd47c650e 100644

--- a/tools/telemetry/telemetry/page/page_set_archive_info_unittest.py

+++ b/tools/telemetry/telemetry/page/page_set_archive_info_unittest.py

@@ -48,7 +48,7 @@ class TestPageSetArchiveInfo(unittest.TestCase):

# Create the PageSetArchiveInfo object to be tested.

self.archive_info = page_set_archive_info.PageSetArchiveInfo.FromFile(

- self.page_set_archive_info_file)

+ self.page_set_archive_info_file, cloud_storage.PUBLIC_BUCKET)

def tearDown(self):

shutil.rmtree(self.tmp_dir)

@@ -157,7 +157,7 @@ class TestPageSetArchiveInfo(unittest.TestCase):

# Create the PageSetArchiveInfo object to be tested.

self.archive_info = page_set_archive_info.PageSetArchiveInfo.FromFile(

- self.page_set_archive_info_file)

+ self.page_set_archive_info_file, cloud_storage.PUBLIC_BUCKET)

# Add a recording for all the pages.

new_temp_recording = os.path.join(self.tmp_dir, 'recording.wpr')

@@ -181,6 +181,6 @@ class TestPageSetArchiveInfo(unittest.TestCase):

# Check that the archive info was written correctly.

self.assertTrue(os.path.exists(self.page_set_archive_info_file))

read_archive_info = page_set_archive_info.PageSetArchiveInfo.FromFile(

- self.page_set_archive_info_file)

+ self.page_set_archive_info_file, cloud_storage.PUBLIC_BUCKET)

self.assertEquals(new_recording,

read_archive_info.WprFilePathForPage(page1))

« no previous file with comments | « tools/telemetry/telemetry/page/page_set_archive_info.py ('k') | tools/telemetry/telemetry/page/page_test_unittest.py » ('j') | no next file with comments »