Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed)

Created:
6 years, 1 month ago by benwells
Modified:
6 years, 1 month ago
Reviewers:
calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, marja+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move app launch metric recording code from NTP to chrome/common. BUG=432720 Committed: https://crrev.com/9196d87fcce71cbc79c5c0bb660dc6b0a9d0c670 Cr-Commit-Position: refs/heads/master@{#304987}

Patch Set 1 #

Patch Set 2 : Added comment #

Patch Set 3 : Rebase #

Patch Set 4 : Fix mac #

Patch Set 5 : More mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -118 lines) Patch
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_result.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/core_app_launcher_handler.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/ntp/core_app_launcher_handler.cc View 3 chunks +4 lines, -50 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A chrome/common/extensions/extension_metrics.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/common/extensions/extension_metrics.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
benwells
calamity: please have a run through before owners...
6 years, 1 month ago (2014-11-14 07:31:23 UTC) #2
calamity
lgtm
6 years, 1 month ago (2014-11-17 00:54:37 UTC) #3
benwells
+sky for owners review
6 years, 1 month ago (2014-11-19 07:17:13 UTC) #5
sky
LGTM
6 years, 1 month ago (2014-11-19 16:06:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725853002/20001
6 years, 1 month ago (2014-11-19 20:18:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/83679) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/814)
6 years, 1 month ago (2014-11-19 20:40:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725853002/80001
6 years, 1 month ago (2014-11-20 06:29:07 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-20 07:11:57 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 07:12:41 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/9196d87fcce71cbc79c5c0bb660dc6b0a9d0c670
Cr-Commit-Position: refs/heads/master@{#304987}

Powered by Google App Engine
This is Rietveld 408576698