chrome/browser/ui/app_list/search/app_result.cc - Issue 725853002: Move app launch metric recording code from NTP to chrome/common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/app_result.cc

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More mac Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/search/app_result.cc

diff --git a/chrome/browser/ui/app_list/search/app_result.cc b/chrome/browser/ui/app_list/search/app_result.cc

index 4f628b349c6c84b23d26f4b5721f2eb5b8ca62af..e064bb2a8f9e92eed3aba107294a85235391b77f 100644

--- a/chrome/browser/ui/app_list/search/app_result.cc

+++ b/chrome/browser/ui/app_list/search/app_result.cc

@@ -12,7 +12,7 @@

#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"

#include "chrome/browser/ui/app_list/search/search_util.h"

#include "chrome/browser/ui/extensions/extension_enable_flow.h"

-#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"

+#include "chrome/common/extensions/extension_metrics.h"

#include "content/public/browser/user_metrics.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

@@ -105,7 +105,7 @@ void AppResult::Open(int event_flags) {

if (RunExtensionEnableFlow())

return;

- CoreAppLauncherHandler::RecordAppListSearchLaunch(extension);

+ extensions::RecordAppListSearchLaunch(extension);

content::RecordAction(

base::UserMetricsAction("AppList_ClickOnAppFromSearch"));

« no previous file with comments | « chrome/browser/ui/app_list/extension_app_item.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »