chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 725853002: Move app launch metric recording code from NTP to chrome/common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More mac Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index aeabeeb1182795108411acbb9ef09be8d4c3dcf9..394aef775cdc9eb2eb7be18590e450e11992d221 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -45,9 +45,9 @@

#include "chrome/browser/ui/views/event_utils.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

-#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "chrome/common/extensions/extension_metrics.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

@@ -346,9 +346,8 @@ void RecordAppLaunch(Profile* profile, GURL url) {

if (!extension)

return;

- CoreAppLauncherHandler::RecordAppLaunchType(

- extension_misc::APP_LAUNCH_BOOKMARK_BAR,

- extension->GetType());

+ extensions::RecordAppLaunchType(extension_misc::APP_LAUNCH_BOOKMARK_BAR,

+ extension->GetType());

}

} // namespace

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »