chrome/browser/sessions/tab_restore_service_helper.cc - Issue 725853002: Move app launch metric recording code from NTP to chrome/common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/tab_restore_service_helper.cc

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More mac Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sessions/tab_restore_service_helper.cc

diff --git a/chrome/browser/sessions/tab_restore_service_helper.cc b/chrome/browser/sessions/tab_restore_service_helper.cc

index 5dab8489d28906dc1c6f617ae325492101764892..766335bb73e05c6ec7b885d7969a19795be6a657 100644

--- a/chrome/browser/sessions/tab_restore_service_helper.cc

+++ b/chrome/browser/sessions/tab_restore_service_helper.cc

@@ -23,8 +23,8 @@

#if defined(ENABLE_EXTENSIONS)

#include "chrome/browser/extensions/tab_helper.h"

-#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "chrome/common/extensions/extension_metrics.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_set.h"

@@ -45,7 +45,7 @@ void RecordAppLaunch(Profile* profile, const TabRestoreService::Tab& tab) {

if (!extension)

return;

- CoreAppLauncherHandler::RecordAppLaunchType(

+ extensions::RecordAppLaunchType(

extension_misc::APP_LAUNCH_NTP_RECENTLY_CLOSED,

extension->GetType());

#endif // defined(ENABLE_EXTENSIONS)

« no previous file with comments | « chrome/browser/sessions/session_restore.cc ('k') | chrome/browser/ui/app_list/extension_app_item.cc » ('j') | no next file with comments »