chrome/browser/sessions/session_restore.cc - Issue 725853002: Move app launch metric recording code from NTP to chrome/common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore.cc

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More mac Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/chrome_management_api_delegate.cc ('k') | chrome/browser/sessions/tab_restore_service_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore.cc

diff --git a/chrome/browser/sessions/session_restore.cc b/chrome/browser/sessions/session_restore.cc

index bac5d42bed83ff89c6dc02369a3ea889db74648f..4e83b8ed4fcb19b78a51e569b96c3c9c2688de6f 100644

--- a/chrome/browser/sessions/session_restore.cc

+++ b/chrome/browser/sessions/session_restore.cc

@@ -35,7 +35,7 @@

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"

+#include "chrome/common/extensions/extension_metrics.h"

#include "chrome/common/url_constants.h"

#include "components/sessions/session_types.h"

#include "content/public/browser/child_process_security_policy.h"

@@ -980,7 +980,7 @@ class SessionRestoreImpl : public content::NotificationObserver {

extensions::ExtensionRegistry::Get(profile())

->enabled_extensions().GetAppByURL(url);

if (extension) {

- CoreAppLauncherHandler::RecordAppLaunchType(

+ extensions::RecordAppLaunchType(

extension_misc::APP_LAUNCH_SESSION_RESTORE,

extension->GetType());

}