Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct (Closed)

Created:
7 years, 1 month ago by tmdiep
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, felt, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move InstallObserver::OnBeginExtensionInstall parameters to a struct The parameters of InstallObserver::OnBeginExtensionInstall() have been moved to a struct to allow additional parameters to be added easily without changing the signature of the function. BUG=None TEST=unit_tests, browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -87 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/install_observer.h View 2 chunks +17 lines, -8 lines 0 comments Download
A chrome/browser/extensions/install_observer.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/extensions/install_tracker.h View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_result.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_result.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tmdiep
The motivation behind this patch is so that I can add/remove an "is_ephemeral" flag to ...
7 years, 1 month ago (2013-11-14 07:05:34 UTC) #1
benwells
lgtm
7 years, 1 month ago (2013-11-15 03:59:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/72463002/1
7 years, 1 month ago (2013-11-17 22:17:03 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 09:33:12 UTC) #4
Message was sent while issue was closed.
Change committed as 235681

Powered by Google App Engine
This is Rietveld 408576698