Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_model_builder.cc
diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc
index 61742c50f9b1a7417831b4fc547412e62919467a..305256d919cb4c802da240488d847d6b297dd79e 100644
--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc
+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc
@@ -57,27 +57,23 @@ ExtensionAppModelBuilder::~ExtensionAppModelBuilder() {
}
void ExtensionAppModelBuilder::OnBeginExtensionInstall(
- const std::string& extension_id,
- const std::string& extension_name,
- const gfx::ImageSkia& installing_icon,
- bool is_app,
- bool is_platform_app) {
- if (!is_app)
+ const ExtensionInstallParams& params) {
+ if (!params.is_app)
return;
- ExtensionAppItem* existing_item = GetExtensionAppItem(extension_id);
+ ExtensionAppItem* existing_item = GetExtensionAppItem(params.extension_id);
if (existing_item) {
existing_item->SetIsInstalling(true);
return;
}
InsertApp(new ExtensionAppItem(profile_,
- extension_id,
+ params.extension_id,
controller_,
- extension_name,
- installing_icon,
- is_platform_app));
- SetHighlightedApp(extension_id);
+ params.extension_name,
+ params.installing_icon,
+ params.is_platform_app));
+ SetHighlightedApp(params.extension_id);
}
void ExtensionAppModelBuilder::OnDownloadProgress(

Powered by Google App Engine
This is Rietveld 408576698