Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: chrome/browser/extensions/install_observer.h

Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/install_observer.h
diff --git a/chrome/browser/extensions/install_observer.h b/chrome/browser/extensions/install_observer.h
index cc79df059274ac697371d4c13ded975bc595193e..47b7455d217bd917b8f95b7e41ccac98d4b7dff8 100644
--- a/chrome/browser/extensions/install_observer.h
+++ b/chrome/browser/extensions/install_observer.h
@@ -7,9 +7,7 @@
#include <string>
-namespace gfx {
-class ImageSkia;
-}
+#include "ui/gfx/image/image_skia.h"
namespace extensions {
@@ -17,12 +15,23 @@ class Extension;
class InstallObserver {
public:
+ struct ExtensionInstallParams {
+ ExtensionInstallParams(
+ std::string extension_id,
+ std::string extension_name,
+ gfx::ImageSkia installing_icon,
+ bool is_app,
+ bool is_platform_app);
+
+ std::string extension_id;
+ std::string extension_name;
+ gfx::ImageSkia installing_icon;
+ bool is_app;
+ bool is_platform_app;
+ };
+
virtual void OnBeginExtensionInstall(
- const std::string& extension_id,
- const std::string& extension_name,
- const gfx::ImageSkia& installing_icon,
- bool is_app,
- bool is_platform_app) = 0;
+ const ExtensionInstallParams& params) = 0;
virtual void OnDownloadProgress(const std::string& extension_id,
int percent_downloaded) = 0;
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/install_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698