chrome/browser/ui/app_list/recommended_apps.h - Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/recommended_apps.h

Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc ('k') | chrome/browser/ui/app_list/recommended_apps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/recommended_apps.h

diff --git a/chrome/browser/ui/app_list/recommended_apps.h b/chrome/browser/ui/app_list/recommended_apps.h

index c89f39af77f304b3b2eee249c86cffdc39a7ae71..e781386ee193083214cf9616fae204205ff68712 100644

--- a/chrome/browser/ui/app_list/recommended_apps.h

+++ b/chrome/browser/ui/app_list/recommended_apps.h

@@ -37,11 +37,8 @@ class RecommendedApps : public extensions::InstallObserver {

void Update();

// extensions::InstallObserver overrides:

- virtual void OnBeginExtensionInstall(const std::string& extension_id,

- const std::string& extension_name,

- const gfx::ImageSkia& installing_icon,

- bool is_app,

- bool is_platform_app) OVERRIDE;

+ virtual void OnBeginExtensionInstall(

+ const ExtensionInstallParams& params) OVERRIDE;

virtual void OnDownloadProgress(const std::string& extension_id,

int percent_downloaded) OVERRIDE;

virtual void OnInstallFailure(const std::string& extension_id) OVERRIDE;