Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3646)

Unified Diff: chrome/browser/extensions/activity_log/activity_log.h

Issue 72463002: Move InstallObserver::OnBeginExtensionInstall parameters to a struct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_log.h
diff --git a/chrome/browser/extensions/activity_log/activity_log.h b/chrome/browser/extensions/activity_log/activity_log.h
index a17b8df274a61fe05feb74cd37f5d5a5c877a7ab..e5af374c0641c340d91a397d35d3fefe2d620249 100644
--- a/chrome/browser/extensions/activity_log/activity_log.h
+++ b/chrome/browser/extensions/activity_log/activity_log.h
@@ -90,11 +90,8 @@ class ActivityLog : public BrowserContextKeyedService,
virtual void OnExtensionUnloaded(const Extension* extension) OVERRIDE;
virtual void OnExtensionUninstalled(const Extension* extension) OVERRIDE;
// We also have to list the following from InstallObserver.
- virtual void OnBeginExtensionInstall(const std::string& extension_id,
- const std::string& extension_name,
- const gfx::ImageSkia& installing_icon,
- bool is_app,
- bool is_platform_app) OVERRIDE {}
+ virtual void OnBeginExtensionInstall(
+ const ExtensionInstallParams& params) OVERRIDE {}
virtual void OnDownloadProgress(const std::string& extension_id,
int percent_downloaded) OVERRIDE {}
virtual void OnInstallFailure(const std::string& extension_id) OVERRIDE {}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698