Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError The impl_'s OnConnectionError may end up deleting the InterfaceImpl, so save off any member variables we wanna look at (like delete_on_error_) in a local before firing the connection error handler. Fixes asan-detected use after frees in view_manager_unittests. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db4745be24823b326b9eeef09d47a1307c4d7726

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	mojo/public/cpp/bindings/binding.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/public/cpp/bindings/interface_impl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

This is the exact same logic InterfaceImpl<> used to have in weak binding that I ...

6 years, 1 month ago (2014-11-13 01:43:10 UTC) #1

jamesr

6 years, 1 month ago (2014-11-13 01:47:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
db4745be24823b326b9eeef09d47a1307c4d7726 (presubmit successful).

Expand Messages | Collapse Messages