mojo/public/cpp/bindings/interface_impl.h - Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/interface_impl.h

Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/interface_impl.h

diff --git a/mojo/public/cpp/bindings/interface_impl.h b/mojo/public/cpp/bindings/interface_impl.h

index 74f541ea5fb4d308947fcf7354258bed3e9cf4ba..9afd1923367248d1aeff25a54a4fb26e9a63727c 100644

--- a/mojo/public/cpp/bindings/interface_impl.h

+++ b/mojo/public/cpp/bindings/interface_impl.h

@@ -59,8 +59,9 @@ class InterfaceImpl : public Interface, public ErrorHandler {

// ErrorHandler implementation:

void OnConnectionError() override {

+ bool delete_on_error = delete_on_error_;

impl_->OnConnectionError();

- if (delete_on_error_)

+ if (delete_on_error)

delete impl_;

}

« no previous file with comments | « mojo/public/cpp/bindings/binding.h ('k') | no next file » | no next file with comments »