mojo/public/cpp/bindings/binding.h - Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/binding.h

Issue 724563003: Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/binding.h

diff --git a/mojo/public/cpp/bindings/binding.h b/mojo/public/cpp/bindings/binding.h

index 9f9c7125296086ec52fb31811fc59049d8abde8e..2c4c9ceb05dc2ecc838b5b11d59252adafdd497f 100644

--- a/mojo/public/cpp/bindings/binding.h

+++ b/mojo/public/cpp/bindings/binding.h

@@ -63,7 +63,7 @@ class Binding : public ErrorHandler {

Bind(request.PassMessagePipe(), waiter);

}

- virtual ~Binding() {

+ ~Binding() override {

delete proxy_;

if (internal_router_) {

internal_router_->set_error_handler(nullptr);

« no previous file with comments | « no previous file | mojo/public/cpp/bindings/interface_impl.h » ('j') | no next file with comments »