Avoid touching members in InterfaceImpl::ErrorHandlerImpl after calling OnConnectionError

mojo/public/cpp/bindings/interface_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_INTERFACE_IMPL_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_INTERFACE_IMPL_H_
 
 #include "mojo/public/cpp/bindings/binding.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "mojo/public/cpp/environment/environment.h"
@@ skipping 41 matching lines @@
   }
 
  private:
   class ErrorHandlerImpl : public ErrorHandler {
    public:
     explicit ErrorHandlerImpl(InterfaceImpl* impl) : impl_(impl) {}
     ~ErrorHandlerImpl() override {}
 
     // ErrorHandler implementation:
     void OnConnectionError() override {
+      bool delete_on_error = delete_on_error_;
       impl_->OnConnectionError();
-      if (delete_on_error_)
+      if (delete_on_error)
         delete impl_;
     }
 
     void set_delete_on_error(bool delete_on_error) {
       delete_on_error_ = delete_on_error;
     }
 
    private:
     InterfaceImpl* impl_;
     bool delete_on_error_ = false;
@@ skipping 94 matching lines @@
 Impl* WeakBindToRequest(
     Impl* instance,
     InterfaceRequest<Interface>* request,
     const MojoAsyncWaiter* waiter = Environment::GetDefaultAsyncWaiter()) {
   return WeakBindToPipe(instance, request->PassMessagePipe(), waiter);
 }
 
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_INTERFACE_IMPL_H_