Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 724183004: Simplify Dictionary::ConversionContext (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Simplify Dictionary::ConversionContext - Nobody uses the forConstructor(). - m_interfaceName and m_methodName are passed, but nobody uses them. BUG=433174 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185360

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 3 chunks +3 lines, -10 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bashi
PTAL?
6 years, 1 month ago (2014-11-14 08:14:22 UTC) #2
haraken
LGTM https://codereview.chromium.org/724183004/diff/1/Source/bindings/core/v8/Dictionary.h File Source/bindings/core/v8/Dictionary.h (right): https://codereview.chromium.org/724183004/diff/1/Source/bindings/core/v8/Dictionary.h#newcode79 Source/bindings/core/v8/Dictionary.h:79: ConversionContext(ExceptionState& exceptionState) Add explicit.
6 years, 1 month ago (2014-11-14 08:22:25 UTC) #3
bashi
Thank you for review! https://codereview.chromium.org/724183004/diff/1/Source/bindings/core/v8/Dictionary.h File Source/bindings/core/v8/Dictionary.h (right): https://codereview.chromium.org/724183004/diff/1/Source/bindings/core/v8/Dictionary.h#newcode79 Source/bindings/core/v8/Dictionary.h:79: ConversionContext(ExceptionState& exceptionState) On 2014/11/14 08:22:24, ...
6 years, 1 month ago (2014-11-14 08:27:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724183004/40001
6 years, 1 month ago (2014-11-14 08:28:20 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 09:37:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as 185360

Powered by Google App Engine
This is Rietveld 408576698